fix(#346): don't advertize python 3.7 support

pyvisa / pyvisa-py

A pure python PyVISA backend

https://pyvisa-py.readthedocs.io

MIT License

282 stars 120 forks source link

fix(#346): don't advertize python 3.7 support #354

Closed sbor23 closed 1 year ago

sbor23 commented 1 year ago

Make sure package managers don't pull newer version for python 3.7

This should have happened in 0.6.0 but I don't think we can fix this. Probably pip will still try to install 0.6.0-0.6.2 for python 3.7, but correctly these releases should be fixed with this patch.

[x] Closes #346
[ ] Executed black . && isort -c . && flake8 with no errors
[ ] The change is fully covered by automated unit tests
[ ] Documented in docs/ as appropriate
[ ] Added an entry to the CHANGES file

MatthieuDartiailh commented 1 year ago

Thanks

sbor23 commented 1 year ago

Do you think this could be somehow be backported to existing 0.6.x releases and push them to pypi?

sbor23 commented 1 year ago

Do you think this could be somehow be backported to existing 0.6.x releases and push them to pypi?

@MatthieuDartiailh what do you think would that be possible? Because people will continue to get invalid versions 0.6.x otherwise.

MatthieuDartiailh commented 1 year ago

The release 0.6.2 supports 3.7 so people should be fine. I could yank the earlier releases but people are unlikely to get them.

sbor23 commented 1 year ago

You're right, no need to yank older versions, but the problem is that 0.6.2 is broken too. So wee probably need first a version that advertizes python 3.7 and works, then we can make a new version that removes python 3.7.

Let's discuss in the issue instead: https://github.com/pyvisa/pyvisa-py/issues/355