search

pyvisa / pyvisa-py

A pure python PyVISA backend
https://pyvisa-py.readthedocs.io
MIT License
282 stars 120 forks source link

Python 3.7 fixes #357

Closed MatthieuDartiailh closed 1 year ago

MatthieuDartiailh commented 1 year ago

@sbor23 can you check this works for you ?

codecov-commenter commented 1 year ago

Codecov Report

Merging #357 (98b6a52) into main (ceb594b) will decrease coverage by 0.10%. The diff coverage is 19.48%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #357      +/-   ##
==========================================
- Coverage   22.41%   22.31%   -0.10%     
==========================================
  Files          21       21              
  Lines        3226     3227       +1     
  Branches      447      448       +1     
==========================================
- Hits          723      720       -3     
- Misses       2485     2487       +2     
- Partials       18       20       +2
Flag Coverage Δ
unittests 22.31% <19.48%> (-0.10%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyvisa_py/tcpip.py 20.51% <19.48%> (-0.23%) :arrow_down:
pyvisa_py/sessions.py 40.50% <0.00%> (-1.00%) :arrow_down:
pyvisa_py/protocols/rpc.py 22.02% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sbor23 commented 1 year ago

Can confirm it works! Thank you!

MatthieuDartiailh commented 1 year ago

The failure is a flake8 complexity issue that I will ignore for now. I will try to merge and release 0.6.3 ASAP and then push the changes disabling 3.7 support and requiring PyVISA 1.13 and maybe some tests if I get a chance.