search

pyvisa / pyvisa-py

A pure python PyVISA backend
https://pyvisa-py.readthedocs.io
MIT License
288 stars 124 forks source link

Fix serial call parameter name. #76

Closed fake-name closed 6 years ago

fake-name commented 8 years ago

Fix for https://github.com/hgrecco/pyvisa-py/issues/75

fake-name commented 8 years ago

This also fixes another bug with the serial data decoding that I think was probably because the code was never tested under python3k.

MatthieuDartiailh commented 7 years ago

@fake-name I fail to see why you decode on text_type, should it be encode ? Furthermore six is not a dependency, so we would need to add it.

fake-name commented 7 years ago

Yeah, I'm not sure how that worked. It did work, at the time, I think?

Anyways, I no longer have access to the hardware I used to pyvisa-py, so I can't really help much. It's been a year and a half!

skrchnavy commented 6 years ago

112 is follower of intended fix. Change in session.py is related to #66 / #70.

I propose to close this PR without merging.

MatthieuDartiailh commented 6 years ago

The issue with timeout parameter is addressed in #112 and the remaining one will be addressed in another PR.