Open_timeout stored in Session

pyvisa / pyvisa-sim

A PyVISA backend that simulates a large part of the "Virtual Instrument Software Architecture" (VISA_)

https://pyvisa-sim.readthedocs.io/en/latest/

MIT License

70 stars 39 forks source link

Open_timeout stored in Session #43

Open skrchnavy opened 6 years ago

skrchnavy commented 6 years ago

parameter open_timeout is passed to session and stored there. Can be used in derived classes. No further processing is done, just interface changes

It aligns code with the change in pyvisa/pyvisa-py#115 due to requirements in pyvisa/pyvisa-py#88

MatthieuDartiailh commented 6 years ago

This breaks all tests because you would need to change the __init__ of all subclasses. I am not sure how useful that is since the simulator does not care about the timeout neither do the user (as I expect user to interact through the highlevel API and not dig into the session). What is your reasoning behind this ?

skrchnavy commented 6 years ago

Reason was to be able to simulate connection timeout. I will check if it is worth to invest there an effort