pyvista / pyiges

Python IGES Reader
https://pyvista.github.io/pyiges/
MIT License
33 stars 8 forks source link

fix/forgotten comma in `CircularArc.to_vtk` #20

Closed germa89 closed 2 years ago

germa89 commented 2 years ago

Hi

Recent update in Pyvista raised that there is a forgotten comma in the method CircularArc.to_vtk (https://github.com/pyvista/pyiges/blob/1df9a8d6004e5f6d8aa37638706ef41d31a08f53/pyiges/geometry.py#L633 ).

I'm not sure why now it is highlighted.

germa89 commented 2 years ago

I created the PR in my own fork:

See https://github.com/pyvista/pyiges/pull/21

germa89 commented 2 years ago

I'm trying to find out why that error is raised now:

I guess I'm missing something here.

Anyway, the proposed PR solves the issue.

akaszynski commented 2 years ago

I'm trying to find out why that error is raised now:

I guess I'm missing something here.

Anyway, the proposed PR solves the issue.

The change was pyvista enforces inputs much more strictly in https://github.com/pyvista/pyvista/pull/1971