pyvista / pyiges

Python IGES Reader
https://pyvista.github.io/pyiges/
MIT License
33 stars 8 forks source link

Circular Arc not correctly represented when converting to VTK #41

Open whliu91 opened 1 year ago

whliu91 commented 1 year ago

when a circular arc is converted to VTK mesh now all arc are represented as minor arc in IGES, this should be determined by the start and end point of an arc which is always counter-clockwise

in pyiges/geometry.py, line 634 (CircularArc.to_vtk())

There should be an extra bool passed to pv.CircularArc to indicate whether the arc is negative (major or minor) or not, determined by the sequence of the two points

pyvista ref (https://docs.pyvista.org/version/stable/api/utilities/_autosummary/pyvista.CircularArc.html)