search

pyvista / pymeshfix

Python Wrapper for MeshFix: easily repair holes in surface meshes
http://pymeshfix.pyvista.org
GNU General Public License v3.0
293 stars 29 forks source link

MAINT: Bump to 3.9 and NumPy 2 #66

Closed larsoner closed 4 months ago

larsoner commented 4 months ago
  1. Make 3.9 the min Python. Should be safe enough nowadays since NumPy 2.0 didn't release 3.8 wheels.
  2. Build against NumPy 2.0
  3. Set version in prep for release

@akaszynski I suggest we merge this PR then cut a 0.17.0 release

Closes #65

akaszynski commented 4 months ago

@akaszynski I suggest we merge this PR then cut a 0.17.0 release

Sure! After merging this, create a new branch release/0.17 and then bump the version on that branch to 0.17.0. Push that commit and then tag with v0.17.0. CI should take care of the rest.

larsoner commented 4 months ago

Pushed, feel free to approve and/or merge @akaszynski (I can't merge myself without an approving review, but marked for merge-when-green-and-approved)

akaszynski commented 4 months ago

Seems that we need to fix our required CI checks...

larsoner commented 4 months ago

Also I don't see the point of building both universal2 and x86_64 wheels on macOS. To me it makes the most sense to build x86_64 on macos-13 and arm64 on macos-14. I'll open a PR to update to this (I think it's cibuildwheel suggested/best practice nowadays)