search

pyvista / pytest-pyvista

Plugin to test PyVista plot outputs
https://pytest.pyvista.org
MIT License
13 stars 5 forks source link

Raise for vtk <9 #21

Closed MatthewFlamm closed 1 year ago

MatthewFlamm commented 1 year ago

vtk v8.x is not supported for image regressions. At least this is how the code works now. Returning None was a workaround in the pyvista package instead of skipping the tests. Now that this package is decoupled, we should raise instead so that users know it isn't supported, otherwise confusion like https://github.com/pyvista/pytest-pyvista/pull/19#issuecomment-1365009955 occurs.

codecov-commenter commented 1 year ago

Codecov Report

Merging #21 (7a57c86) into main (374c284) will not change coverage. The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main      #21   +/-   ##
=======================================
  Coverage   83.78%   83.78%           
=======================================
  Files           2        2           
  Lines          74       74           
=======================================
  Hits           62       62           
  Misses         12       12
Impacted Files Coverage Δ
pytest_pyvista/pytest_pyvista.py 83.56% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

MatthewFlamm commented 1 year ago

Closing in favor of #19