MatthewFlamm commented 1 year ago

Closes #17 and closes #6. Allow saving generated images to dir.

TODO:

[x] Add option to append new images to image cache (needed to avoid users moving all new files to image cache)
[x] ~Reverse option for failing with extra image? IMO, it should be defaulted to fail here and an option to not fail.~ Will leave for a different PR

codecov-commenter commented 1 year ago

Codecov Report

Merging #22 (3a88ef2) into main (8ea9f78) will increase coverage by 2.71%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   87.50%   90.21%   +2.71%     
==========================================
  Files           2        2              
  Lines          80       92      +12     
==========================================
+ Hits           70       83      +13     
+ Misses         10        9       -1

Impacted Files	Coverage Δ
pytest_pyvista/pytest_pyvista.py	`90.10% <100.00%> (+2.76%)`	:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

MatthewFlamm commented 1 year ago

This PR is not really a breaking change for adding missing images since this functionality didn't work on the previous releases. See #17

Edit: Although it is a breaking change for pyvista

MatthewFlamm commented 1 year ago

Merging this after prior approval and merging with main with only minor changes afterwards.

pyvista / pytest-pyvista

Allow saving generated images to dir #22

Codecov Report