search

pyvista / pytest-pyvista

Plugin to test PyVista plot outputs
https://pytest.pyvista.org
MIT License
13 stars 5 forks source link

Use instance attributes for high variance and skipping based on os #23

Closed MatthewFlamm closed 1 year ago

MatthewFlamm commented 1 year ago

The current class attributes mean that the values leak out of tests into other tests. Using instance attributes fixes this problem as the VerifyImageCache object is intended to be initialized in a fixture for each test.

Additional tests were added for high variance tests, but not the OS specific skips.

codecov-commenter commented 1 year ago

Codecov Report

Merging #23 (7954264) into main (8c46ad5) will increase coverage by 2.66%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   86.66%   89.33%   +2.66%     
==========================================
  Files           2        2              
  Lines          75       75              
==========================================
+ Hits           65       67       +2     
+ Misses         10        8       -2
Impacted Files Coverage Δ
pytest_pyvista/pytest_pyvista.py 89.18% <100.00%> (+2.70%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.