search

pyvista / pytest-pyvista

Plugin to test PyVista plot outputs
https://pytest.pyvista.org
MIT License
13 stars 5 forks source link

Option for skipping on vtk8 #26

Closed MatthewFlamm closed 1 year ago

MatthewFlamm commented 1 year ago

pyvista tests include plotting with vtk version 8 but do not support image caching. However, it is still useful to test that the tests run on these versions without error. This PR adds the option to raise an error for vtk8 (default) or skip image cache testing.

This would fix vtk version related failures for https://github.com/pyvista/pyvista/pull/3748

codecov-commenter commented 1 year ago

Codecov Report

Merging #26 (406b386) into main (9e6327e) will decrease coverage by 1.83%. The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   89.33%   87.50%   -1.84%     
==========================================
  Files           2        2              
  Lines          75       80       +5     
==========================================
+ Hits           67       70       +3     
- Misses          8       10       +2
Impacted Files Coverage Δ
pytest_pyvista/pytest_pyvista.py 87.34% <50.00%> (-1.85%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

banesullivan commented 1 year ago

Merging and releasing