Conflicting flags do not raise an error or warning.

pyvista / pytest-pyvista

Plugin to test PyVista plot outputs

https://pytest.pyvista.org

MIT License

13 stars 5 forks source link

Conflicting flags do not raise an error or warning. #36

Open AlejandroFernandezLuces opened 1 year ago

AlejandroFernandezLuces commented 1 year ago

The flags --fail_extra_image_cache and --add_missing_images are incompatible with each other. This is not documented anywhere. We should:

Update the documentation to cover this.
Choose what flag will take priority in case of conflict.
Raise a warning in the code to notify that both flags are incompatible when both flags are active, and tell the user which one is prioritized.

MatthewFlamm commented 1 year ago

I think it would better to have the default to fail on extra images. Then options like add-missing-images and so on would modify this behavior. Is there any scenario we'd want to have a passing test with extra images created without these other flags in use?