search

pyvista / pytest-pyvista

Plugin to test PyVista plot outputs
https://pytest.pyvista.org
MIT License
13 stars 5 forks source link

Remove vtk8 handling #44

Closed MatthewFlamm closed 1 year ago

MatthewFlamm commented 1 year ago

This PR removes vtk8 handling.

This is related to https://github.com/pyvista/pyvista/pull/4018.

codecov-commenter commented 1 year ago

Codecov Report

Merging #44 (ce5d8c3) into main (00b8dc8) will increase coverage by 2.63%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   90.21%   92.85%   +2.63%     
==========================================
  Files           2        2              
  Lines          92       84       -8     
==========================================
- Hits           83       78       -5     
+ Misses          9        6       -3
Impacted Files Coverage Δ
pytest_pyvista/pytest_pyvista.py 92.68% <ø> (+2.68%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

MatthewFlamm commented 1 year ago

I recommend waiting until https://github.com/pyvista/pyvista/pull/3938 is merged before also dropping python 3.7 support here. It will be easier overall.

MatthewFlamm commented 1 year ago

Shall we have a new patch release for this? At some point we will have to start doing minor releases, but this package still feels in the alpha/early-beta stage.