search

pyvista / pytest-pyvista

Plugin to test PyVista plot outputs
https://pytest.pyvista.org
MIT License
13 stars 5 forks source link

Fix CI; Remove python 3.7; remove flake8-isort #66

Closed MatthewFlamm closed 1 year ago

MatthewFlamm commented 1 year ago

CI is starting to fail due to conflicts with python 3.7. PyVista no longer supports this version, so we should drop here too.

codecov-commenter commented 1 year ago

Codecov Report

Merging #66 (6ffc2b3) into main (95da764) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #66   +/-   ##
=======================================
  Coverage   92.13%   92.13%           
=======================================
  Files           2        2           
  Lines          89       89           
=======================================
  Hits           82       82           
  Misses          7        7
MatthewFlamm commented 1 year ago

flake8-isort is broken due to incompatibility with the newest version of flake8. We already have isort so it is unneeded and flake8-isort has an unfavorable license. Finally isort needed to be updated to fix a poetry installation issue.