search

pyvista / pytest-pyvista

Plugin to test PyVista plot outputs
https://pytest.pyvista.org
MIT License
13 stars 5 forks source link

NEP29 Compliance #85

Open bjlittle opened 1 year ago

bjlittle commented 1 year ago

This PR adopts the NEP29 Drop Schedule for minimum supported versions of python and numpy.

When working on #84 I noticed that the PyPI versions were wrong for pytest-pyvista. Turns out, incorrect syntax (probably migrated from setup.py or setup.cfg) was used to specify the required python version for the package; minor fix sorted this.

Went the extra mile and also configured the validate-pyproject pre-commit hook to automate continued confidence in the pyproject.toml.

bjlittle commented 1 year ago

Thanks! I wondered the same thing. About adding validate-pyproject, also need to ask the @MatthewFlamm if it would be useful to add as it would increase run time. If it is adopted here, please consider sending an additional PR to pyvista/pyvista too.

@tkoyama010 Cool, thanks.

Although, it seems to be a relatively snappy pre-commit hook. I'm not seeing much difference in runtime or resources being used.

codecov-commenter commented 1 year ago

Codecov Report

Merging #85 (5c26917) into main (42f771b) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #85   +/-   ##
=======================================
  Coverage   92.13%   92.13%           
=======================================
  Files           2        2           
  Lines          89       89           
=======================================
  Hits           82       82           
  Misses          7        7
MatthewFlamm commented 1 year ago

Since this package is required for testing pyvista, we can't drop python 3.8 support without dropping it in PyVista. We should probably move the discussion there.

tkoyama010 commented 1 year ago

Oh, I see. I totally forgot this project was used in PyVista😅.

tkoyama010 commented 1 year ago

I started https://github.com/pyvista/pyvista/discussions/4960 . Let's discuss it there!

bjlittle commented 1 year ago

@MatthewFlamm and @tkoyama010

Whilst we await a decision on this one, I'm going to put the pull-request into draft to ensure it's not merged 👍