search

pyvista / pytest-pyvista

Plugin to test PyVista plot outputs
https://pytest.pyvista.org
MIT License
13 stars 5 forks source link

Renaming CLI argument #92

Open germa89 opened 12 months ago

germa89 commented 12 months ago

Renaming fail_extra_image_cache argument to fail_if_missing_image_cache, since this new name is more self-explanatory. It might be a bit too long. I'm happy to delete the _if part if needed.

codecov-commenter commented 12 months ago

Codecov Report

Merging #92 (27e1e1a) into main (ba7b24d) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #92   +/-   ##
=======================================
  Coverage   96.00%   96.00%           
=======================================
  Files           2        2           
  Lines         100      100           
=======================================
  Hits           96       96           
  Misses          4        4
Files Coverage Δ
pytest_pyvista/pytest_pyvista.py 95.91% <100.00%> (ø)
akaszynski commented 12 months ago

@MatthewFlamm, it's your call.

MatthewFlamm commented 12 months ago

I'm +1. I assume there are only a few downstream users of this package. Should we deprecate the old one and make it a temporary alias? I'm fine just hard removing it too given how young this package is.

germa89 commented 11 months ago

I would just remove it...

MaxJPRey commented 11 months ago

I would just remove it too. I will notify people making usage of it in PyAnsys packages.