search

pyvista / pyvista-xarray

xarray DataArray accessors for PyVista
Apache License 2.0
101 stars 7 forks source link

Support nodata values #35

Open banesullivan opened 2 years ago

banesullivan commented 2 years ago

Potential solution to #34

It's a bit dirty as it modifies the data in place or creates a copy of the integer data to float dtype (potentially expensive).

This is my first pass at this, but I'd like to look into some other ways of going about this that do not have as bad of side effects

cc @giswqs

codecov-commenter commented 2 years ago

Codecov Report

Merging #35 (0101820) into main (e19eab1) will decrease coverage by 3.85%. The diff coverage is 52.17%.

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
- Coverage   90.73%   86.87%   -3.86%     
==========================================
  Files           8        8              
  Lines         205      221      +16     
==========================================
+ Hits          186      192       +6     
- Misses         19       29      +10
Impacted Files Coverage Δ
pvxarray/accessor.py 80.64% <42.10%> (-15.19%) :arrow_down:
pvxarray/errors.py 100.00% <100.00%> (ø)
pvxarray/rectilinear.py 97.05% <100.00%> (ø)
pvxarray/structured.py 85.29% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.