pyvista / scikit-gmsh

Scikit for Gmsh to generate 3D finite element mesh
https://scikit-gmsh.readthedocs.io/en/latest
GNU General Public License v3.0
40 stars 1 forks source link

Fix timing of `remove_all_duplicates` in `Delaunay3D` class #387

Closed tkoyama010 closed 2 weeks ago

tkoyama010 commented 2 weeks ago

Overview

The gmsh.model.geo.remove_all_duplicates() function is used to remove duplicates, but it should be called at the appropriate time. Generally, this should be done after defining all geometry and before the final synchronize().

Details

tkoyama010 commented 2 weeks ago

@all-contributors please add @tkoyama010 for code

allcontributors[bot] commented 2 weeks ago

@tkoyama010

@tkoyama010 already contributed before to code

tkoyama010 commented 2 weeks ago

LGTM