search

pyvista / setup-headless-display-action

GitHub Action to setup a headless display on Linux and Windows (not needed on MacOS)
MIT License
19 stars 4 forks source link

wrap qt app install command, add 4 more libs #14

Closed tlambert03 closed 5 months ago

tlambert03 commented 5 months ago

closes #13

as a shot in the dark, this PR wraps the command to install qt-libs in action.yml, it also added four more libraries that are present in setup-qt-libs, which may be used in certain Qt applications

tlambert03 commented 5 months ago

@larsoner ... possible that the actions aren't running due to inactivity here?

larsoner commented 5 months ago

Yep just reenabled, can you push an empty commit?

larsoner commented 5 months ago

Also you can see the tests are super basic... if you have widely used modules that would catch some of those new system libraries feel free to add them (but not required)

tlambert03 commented 5 months ago

yeah, I'm afraid it's been a while since I determined the list that I used in setup-qt-libs... i'll dig for a moment and see if I can find a good test case, but may give up :)

larsoner commented 5 months ago

Hah, tests fail because the macos-latest now means macos-14. I'll open a separate PR to fix CIs while you look!

tlambert03 commented 5 months ago

side-note, d5e79a9 bumped the action versions and changed python 3.9 to 3.10 (needed unless we want to use an older macos runner)

tlambert03 commented 5 months ago

ah ok :) will undo here

larsoner commented 5 months ago

There is a conflict, I can fix it if you want or feel free to push

tlambert03 commented 5 months ago

no worries, got it.

larsoner commented 5 months ago

Thanks @tlambert03 !

tlambert03 commented 5 months ago

thanks!

tlambert03 commented 5 months ago

will follow up with better tests in #17