search

pyvista / setup-headless-display-action

GitHub Action to setup a headless display on Linux and Windows (not needed on MacOS)
MIT License
19 stars 4 forks source link

ENH: Add qt and pyvista options #7

Closed larsoner closed 1 year ago

larsoner commented 1 year ago
  1. Add pyvista: true default option to make it clear that by default env vars are set for PyVista offscreen mode
  2. Add qt: false default option to allow true to add libraries needed for Qt
  3. Create tests/ directory and move test_pyvista.py there
  4. Add test that Qt works on all platforms (easily done via matplotlib)

@banesullivan to me Qt is in scope even for the PyVista org, as we can/should use this for PyVistaQt!

larsoner commented 1 year ago

@banesullivan actions are not running, can you either give me admin access or reenable them via e.g. https://github.com/pyvista/setup-headless-display-action/actions/runs/4060937001 or somewhere similar? I think if they aren't run for a month or so they get deactivated...

banesullivan commented 1 year ago

Workflows are enabled. Not running here due to syntax error

banesullivan commented 1 year ago

to me Qt is in scope even for the PyVista org, as we can/should use this for PyVistaQt!

Fair enough! These changes seem straightforward enough

larsoner commented 1 year ago

Not running here due to syntax error

Not quite -- they weren't running at all before your close/reopen. Now that you've done that, though, I am getting entries in the run where I can see the syntax errors!

banesullivan commented 1 year ago

Right, poor wording on my part: I "re-enabled" the workflows, open/close cycle to trigger the run, then saw the syntax error

banesullivan commented 1 year ago

We've been having trouble with system_supports_plotting for a while... maybe we just strip that out?

See also:

larsoner commented 1 year ago

For now I added this:

      # TODO: Pyvista uses `xset` which is part of x11-xserver-utils, maybe a better way to check?
      run: sudo apt update && sudo apt install libgl1-mesa-glx xvfb x11-xserver-utils -y

it makes it work on Ubuntu here at least. Now just need to fix the Qt test!

larsoner commented 1 year ago

Okay all green! @banesullivan if you give me admin permissions I'm happy to set up now-standard-ish stuff (suggest merge with main, branch protections, only squash+merge, by default use PR title, etc.)

banesullivan commented 1 year ago

Just configured some of those things and made you admin here

banesullivan commented 1 year ago

@larsoner, do you want to merge and tag?

banesullivan commented 1 year ago

This should likely be v2 now and we may need to update the example