search

pyviz / pyviz.org

Source for the PyViz.org website.
https://pyviz.org
Other
150 stars 50 forks source link

Add conda bits to shiny for python #137

Closed asmith26 closed 1 year ago

asmith26 commented 1 year ago

Fixes https://github.com/pyviz/pyviz.org/issues/136

jbednar commented 1 year ago

Oops; somehow I didn't notice this and already added shiny separately. Your changes look great, and include conda-forge bits that mine did not. If it's not too much trouble, can you please rebase and make these changes on the latest master? If not, I'll just grab those bits and apply them myself.

asmith26 commented 1 year ago

Hi @jbednar, no problem at all, thanks for adding this (and sorry for my slowness). I think I've done what you suggested (I couldn't seem to rebase so merged instead (I'm still learning git), but I think you may be able to rebase and/or squash this PR into a single commit if you merge - feel free to change/add to/fix anything if helpful).

Thanks again for your help, and for all your amazing work! :)

jbednar commented 1 year ago

Looks great, thanks!