search

pyviz / pyviz.org

Source for the PyViz.org website.
https://pyviz.org
Other
151 stars 50 forks source link

Remove the dev site from the holoviz-dev Github org and more clean up #177

Open maximlt opened 8 months ago

maximlt commented 8 months ago

I just noticed that the dev site (that can currently be built pushing a commit message containing website_dev) is still hosted on the holoviz-dev organization at https://github.com/holoviz-dev/website. It should be moved to this organization and the code adapted in this repository.

EDIT:

https://github.com/pyviz-developers is a service account that was used by this repository and other HoloViz repositories for pushing commits to the repo (in this case to the cache branch) from the CI. Now the CI is based on Github Actions, this account is no longer required for this, setting workflow permissions is enough and this change has already been implemented.

However, I recently discovered that GitHub service accounts can have another usage: allowing to deploy a dev site on another repository. This is a pattern that most HoloViz projects rely on, they have an associated repository (e.g. https://github.com/holoviz-dev/panel for https://github.com/holoviz/panel) whose purpose it simply to host the dev build of their documentation. The GitHub action that deploys the dev site to the other repo needs a personal access token with repo rights, generated for an account that has write access to the associated repo.

In practice, it turns out the pyviz-developers account isn't used for that purpose, it's Philipp's account+token :)

image

I think having to maintain a service account (pyviz-developers) and its personal access token is too much overhead for the PyViz project. The dev site isn't even linked properly on the README (that's the right link https://holoviz-dev.github.io/website/) so I think contributors aren't aware of its existence.

My suggestions:

@jbednar if you agree with these suggestions, I won't be able to address the last one as I don't have enough rights to remove the token. I don't know if it is set at the repo or org level? So either someone with sufficient permission does it, or someone adds me/edits my role so I can do it (I'm happy to contribute to PyViz in general!).

In the future, it may be possible to re-add a dev site (in fact, a temporary dev site per PR):

maximlt commented 7 months ago

@jbednar gentle ping

jbednar commented 7 months ago

I'm happy with all those changes, thanks. Let me know when you want me to remove the token.

maximlt commented 7 months ago

Alright, you can do it anytime. I'll do the other tasks.

maximlt commented 7 months ago

The pyviz-developers account can only be removed when it's no longer an Owner of the pyviz organization.

image