search

pywikibot-catfiles / file-metadata

A python package to analyze files and provide useful metadata
MIT License
15 stars 1 forks source link

Reduce complexity of bot script code #76

Open drtrigon opened 8 years ago

drtrigon commented 8 years ago

Thanks to https://github.com/pywikibot-catfiles/file-metadata/pull/75 we can see now some issues because of complexity:

setupdeps.py:152:1: C901 'SetupPackage.install_help_msg' is too complex (20)
file_metadata/_compat.py:55:1: C901 'TryExcept 55' is too complex (14)
file_metadata/image/image_file.py:74:1: C901 'ImageFile.fetch' is too complex (12)
file_metadata/image/image_file.py:138:1: C901 'ImageFile.analyze_geolocation' is too complex (13)
file_metadata/image/image_file.py:302:1: C901 'ImageFile.analyze_color_info' is too complex (13)
file_metadata/image/image_file.py:469:1: C901 'ImageFile.analyze_face_haarcascades' is too complex (24)
file_metadata/image/image_file.py:702:1: C901 'ImageFile.analyze_barcode_zxing' is too complex (12)
file_metadata/wikibot/generate_user_files.py:93:1: C901 'get_site_and_lang' is too complex (12)
file_metadata/wikibot/generate_user_files.py:217:1: C901 'create_user_config' is too complex (14)
file_metadata/wikibot/log_bot.py:116:1: C901 'handle_bulk_pages' is too complex (124)
file_metadata/wikibot/log_bot.py:748:1: C901 'main' is too complex (12)
file_metadata/wikibot/simple_bot.py:56:1: C901 'handle_meta' is too complex (20)

as noted by @jayvdb the main issue is a complexity of 124 in file_metadata/wikibot/log_bot.py:116:1: 'handle_bulk_pages'.

jayvdb commented 7 years ago

The wikibot code should be moved out of this package, to enforce better separation of concerns.