Added pycatchmod.io and click module

pywr / pycatchmod

A Cython implementation of the rainfall runoff model CATCHMOD (Wilby, 1994)

GNU General Public License v3.0

6 stars 5 forks source link

Added pycatchmod.io and click module #17

Closed snorfalorpagus closed 7 years ago

snorfalorpagus commented 7 years ago

This PR bundles a few changes together:

Added a command line interface using click, "pycatchmod"
Added io submodule to read excel data (parameters, inputs, results)
Added a run_catchmod function for convenience

snorfalorpagus commented 7 years ago

I think there are still some issues with the way the Excel model stores some of the parameters, but that's left for another issue/PR.

snorfalorpagus commented 7 years ago

There aren't any tests for the Excel parts because we'd have to upload one of the Excel models, which I don't think we can share. I guess we could create something that had the same structure?

jetuk commented 7 years ago

I guess it would then be very clear what Excel layout the code supports?

snorfalorpagus commented 7 years ago

I've added some tests for the Excel read functions that use a dummy "thames.xls" file. This file includes the minimum amount of data for the functions to work.

I think this is ready for merge now. There are some outstanding issues related to the different ways parameters are stored in Excel / pycatchmod and I'd also like to add a flag to the CLI to not automatically add leap days, but those are for another PR.