jetuk
commented
1 week ago One issue I did find when testing using the delay parameter as a simple parameter is that the
aftermethod is not currently called simple parameters.
This is now fixed. It's ready for a final review.
This is designed as an alternative to https://github.com/pywr/pywr-next/pull/192.
The high level idea is the solve the circular parameter issue with initial volumes by recognising that some parameters do not vary in time and/or depend no node state.
We introduce the General, Simple and Constant parameters as new traits:
GeneralParameter- rename of the current implementation.SimpleParameter- Parameters that only depend on other Simple or Constant parameters, but do vary in time.ConstantParameter- Parameters that only depend on other Constant parameters, and do not vary in time.Simple parameters are evaluated before general and
.beforemethods each time-step. This allows them to vary in time, but means that can't depend on network or general parameter values. This is most relevant for profiles which have no dependencies but do vary in time.Constant parameters would be evaluated at the beginning of the simulation only. NB, this is not yet implemented.
Some parameters can potentially implement one or more of these traits. For example, the AggregatedParameter is implemented for General and Simple depending on whether it is aggregating over MetricF64 or SimpleMetricF64. This allows the user to use an aggregated parameter as a simple parameter provided it is only aggregating over simple parameters. From the schema point of view there is no difference. When added to the core model it attempts to add it as a simplified version if possible.
@Batch21 @s-simoncelli @laurenpetch any thoughts on this vs #192 ? Sorry, it's a big refactor / change this one.