search

pyx-project / pyx

Repository of PyX, a Python package for the creation of PostScript, PDF, and SVG files.
https://pyx-project.org/
GNU General Public License v2.0
109 stars 18 forks source link

replace distutils by setuptools to avoid warning #6

Closed gertingold closed 5 years ago

gertingold commented 5 years ago

distutils.core issues a UserWarning complaining about the python_requires and extras_require keywords (cf. https://sourceforge.net/p/pyx/mailman/message/36733909/). It seems that this should be solved by switching to setuptools which is proposed in this PR. It should be checked though whether this is indeed the right thing to do.

wobsta commented 5 years ago

We did wrong in using distutils.core here, but we should better go back and support it both. Turns out it works due to pip, which patches source dist install provided by distutils.core. I have to have a more detailed look into it. (For some reason I seem to not get any mailing list emails anymore. Need to investigate that, too.)

wobsta commented 5 years ago

We should not make PyX depend on something, we do not really need to depend on. And this includes setuptools, although it is just for running setup. (*) We may go back and support both, setuptools and distutils. Whether we need to skip features not available in distutils or we should keep them in place and just accept warnings, is something I have not yet decided upon. It might result in just keeping it the way it is ...

(Comments are very welcome. We might also go back to the maling list, as I am resubscribed now. I just didn't notice until now, and have not seen the recent emails since ... I don't know.)

(*) We are in the nice situation, that PyX does not depend on anything, which is something I want to keep.