pyxem / diffsims

An open-source Python library providing utilities for simulating diffraction
https://diffsims.readthedocs.io
GNU General Public License v3.0
46 stars 26 forks source link

Minor preparations for a 0.5 release #182

Closed hakonanes closed 2 years ago

hakonanes commented 2 years ago

Description of the change

These are some minor preparations for a 0.5 release:

Question: should we add a black code style check to the CI build action?

Progress of the PR

For reviewers

pc494 commented 2 years ago

This looks good to me so far, I do think a .zenodo file would be good.

hakonanes commented 2 years ago

@pc494 could you make me a maintainer of diffsims on PyPI? With the updated publish workflow, we have to add tokens named PYPI_API_TOKEN and TEST_PYPI_API_TOKEN with tokens from both PyPI and TestPyPI to repo secrects (and can delete the PyPI username and password).

hakonanes commented 2 years ago

The meaning of direction=crystal2lab changed from orix 0.8.2 to direction=lab2crystal in 0.9.0. from_euler() is used when generating rotation lists. In order for diffsims to stay consistent, I changed use of from_euler() to use the default direction, which is lab2crystal, and set the minimal version of orix to 0.9.0.

hakonanes commented 2 years ago

See #183 raised by @emichr, which must be fixed before releasing diffsims 0.5.0.

pc494 commented 2 years ago

@pc494 could you make me a maintainer of diffsims on PyPI? With the updated publish workflow, we have to add tokens named PYPI_API_TOKEN and TEST_PYPI_API_TOKEN with tokens from both PyPI and TestPyPI to repo secrects (and can delete the PyPI username and password).

I was considering make pyxem team credentials with PyPi to clean up this part of the workflow? Would now be a suitable time to do that?

hakonanes commented 2 years ago

Do you mean making a pyxem team PyPI user? With the pyxem mail?

pc494 commented 2 years ago

Do you mean making a pyxem team PyPI user? With the pyxem mail?

That was my thought?

hakonanes commented 2 years ago

I'm OK with that. Could you send me the password for PyPI and TestPyPI after creation?

pc494 commented 2 years ago

I'm OK with that. Could you send me the password for PyPI and TestPyPI after creation?

I'll find a secure way to circulate those details to you. The main point was to use them as the automated once in github. Also, before then I'll add you (normal account) to diffsims, sorry for the delay on that.

hakonanes commented 2 years ago

The two failing tests were fixed in #184.

hakonanes commented 2 years ago

I'll fix the conflict myself, and then this PR is ready.