Fix hexagonal corners of fundamental sector in stereographic projection - Githubissues

pyxem / diffsims

An open-source Python library providing utilities for simulating diffraction

https://diffsims.readthedocs.io

GNU General Public License v3.0

46 stars 26 forks source link

Fix hexagonal corners of fundamental sector in stereographic projection #184

Closed hakonanes closed 2 years ago

hakonanes commented 2 years ago

Description of the change

Change the rounded hexagonal corner [10-10] to the exact [9 1 -10 0]. See #183 for details.

Also fixed a rounding error in a test when coordinates passed to DiffractionSimulation where integers and not floats.

Progress of the PR

[n/a] Docstrings for all functions
[n/a] Unit tests with pytest for all lines
[x] Clean code style by running black

For reviewers

[x] The PR title is short, concise, and will make sense 1 year later.
[x] New functions are imported in corresponding __init__.py.
[x] New features, API changes, and deprecations are mentioned in the unreleased section in CHANGELOG.rst.