Closed hakonanes closed 2 years ago
There are many line additions in this PR, however:
ReciprocalLatticePoint
, which is deprecated in this PR in favour of ReciprocalLatticeVector
I hope the docstring examples and inline comments are sufficient to understand the code.
EDIT: Generation of sets of vectors and calculation of structure factors have been compared for cubic, hexagonal and monoclinic phases to the Bruker DynamicS software.
EDIT 2: See the reference docs generated from this PR for an overview of the new class.
No pyxem tests in the current master
branch fail when run on Ubuntu with this PR's version of diffsims.
I'll be able to review this tomorrow, so we can probably get 0.5.0 out next week?
That would be fantastic, thank you Phillip. If this is merged tomorrow I suggest we release 0.5.0 right away.
Tomorrow works for me, will try and get my review in early in that case
Fantastic, thank you a lot, Phillip. I'll update the release date in the changelog in #187, then we can merge that and publish 0.5.0.
Description of the change
This PR introduces a new class
ReciprocalLatticeVector
, replacingReciprocalLatticePoint
for creation and handling of sets of reciprocal lattice vectorshk(i)l
. The latter class only supported cubic phases, while the new class supports all crystallographic point groups. It does so by relying onorix
for all (symmetrically reduced) vector handling viaMiller
, while not directly extending that class since the new class does not support direct lattice vectors. A new class is necessary, instead of just usingMiller
, for easy calculation of structure factors and Bragg angles. This class will be used inkikuchipy
for (existing) geometrical and (to come) kinematical EBSD simulations.This is the last thing I'd like to get released in v0.5.
Closes #144.
Progress of the PR
ReciprocalLatticePoint
Minimal example of the bug fix or new feature
For reviewers
__init__.py
.CHANGELOG.rst
.credits
indiffsims/release_info.py
and in.zenodo.json
.