Closed CSSFrancis closed 5 months ago
Some of these things would be good to do but would require more developer time than I think we currently have.
I would shoot for getting in #201 and then calling it good for a 0.6.0 release.
@hakonanes how do you feel about making a pre-release after #205, #213 , #199 are merged?
Then we can test the orientation mapping in pyxem just to make sure things are wokring the way we would like.
Sounds good. You're thinking of a release candidate on PyPI?
Sounds good. You're thinking of a release candidate on PyPI?
Yea, it just makes it easier for testing in pyxem as we can just install the rc rather than installing from the github repo. It probably really doesn't matter too much but maybe someone else out there is curious and wants to try it :)
I'll make a release PR after #209 is in. We can discuss and release tomorrow, if people are OK with this.
The release PR is #216.
I assume you're busy the HyperSpy workshop, @CSSFrancis. Since you're the one asking for the release, we can wait until you give the go-ahead.
@hakonanes I'll wait until the CI finishes and then merge then we can go ahead!
Here're my suggested release notes (https://github.com/pyxem/diffsims/releases):
diffsims 0.6rc1 is a minor release of diffsims, an open source Python library focussed on the simulation of diffraction patterns.
See below, the changelog or the GitHub changelog for all updates from the previous release.
get_hkl()
, get_highest_hkl()
, and get_equivalent_hkl()
methods in the
crystallography module. Please use the following corresponding methods in the
ReciprocalLatticeVector
class instead: from_highest_hkl()
,
from_min_dspacing()
, and symmetrise()
.ReciprocalLatticePoint
class; Use the ReciprocalLatticeVector
class instead,
which is an improved replacement.StructureLibrary.from_crystal_systems()
class method, which previously raised a
NotImplementedError
, but now will throw an AttributeError
instead.0.6rc1 is out on PyPI. Can be installed with pip install --pre diffsims
.
We could make a pre-release build on conda-forge (explained here), but I don't think it's necessary.
@CSSFrancis, what needs to be done before we release 0.6.0 proper?
@hakonanes thank you so much for your help with this! I don't think we really want to do a pre-release on cond-forge (just sounds like a lot of work).
As far as a workflow before relasing 0.6.0 proper:
We don't necessarily need to merge everything but as I don't do much in the way of orientation mapping I would love to have some feed back before things get merged. My current goal is to make a pyxem 0.19.0 rc hopefully tomorrow and then we can do some testing with that.
I think we can probably go ahead with this. I've been using this for a couple of weeks now with no issues so we can make the 0.6.0 release.
Sounds good, I'll do it right away.
Just creating an issue tracking what needs to be done before a 0.6.0 release. My plan is to have this release be at least (semi-stable) and potentially we could think about a 1.0.0 release not to long after. With a 1.0.0 pyxem/ kikuchipy releases in the future we probably need a more stable
diffsims
package as well...Package Maintenance etc.
Redesign Simulations:
Phase
class inDiffractionGenerator
#201orix
https://github.com/pyxem/orix/pull/460Phase
class. #201Refactors:
AtomicDiffractionGenerator
to its own file. I'm not sure if this really should be in diffsims. With packages likeabTEM
which do this quite a bit better this seems a bit redundant. But maybe others disagree?Removals/Deprecations:
StructureLibrary
--> Removal in 0.7.0ReciprocalLatticePoint
per deprecation warningrotation_list_generators
,sphere_mesh_generators
andzap_map_generators
All sampling should be moved toorix
VectorLibrary
-->Removal in 0.7.0 (I think the VectorLibrary is just another instance of theAtomicDiffractionGenerator
??? This functionality is a bit hard to maintain??? Considering things like abTEM exist I'd consider removing this if there isn't too much objection as you can just do a dynamical simulation...