pyxem / diffsims

An open-source Python library providing utilities for simulating diffraction
https://diffsims.readthedocs.io
GNU General Public License v3.0
46 stars 26 forks source link

0.6.0 Release #200

Closed CSSFrancis closed 5 months ago

CSSFrancis commented 1 year ago

Just creating an issue tracking what needs to be done before a 0.6.0 release. My plan is to have this release be at least (semi-stable) and potentially we could think about a 1.0.0 release not to long after. With a 1.0.0 pyxem/ kikuchipy releases in the future we probably need a more stable diffsims package as well...

Package Maintenance etc.

Redesign Simulations:

Refactors:

Removals/Deprecations:

CSSFrancis commented 8 months ago

Some of these things would be good to do but would require more developer time than I think we currently have.

I would shoot for getting in #201 and then calling it good for a 0.6.0 release.

CSSFrancis commented 6 months ago

@hakonanes how do you feel about making a pre-release after #205, #213 , #199 are merged?

Then we can test the orientation mapping in pyxem just to make sure things are wokring the way we would like.

hakonanes commented 6 months ago

Sounds good. You're thinking of a release candidate on PyPI?

CSSFrancis commented 6 months ago

Sounds good. You're thinking of a release candidate on PyPI?

Yea, it just makes it easier for testing in pyxem as we can just install the rc rather than installing from the github repo. It probably really doesn't matter too much but maybe someone else out there is curious and wants to try it :)

hakonanes commented 6 months ago

I'll make a release PR after #209 is in. We can discuss and release tomorrow, if people are OK with this.

hakonanes commented 6 months ago

The release PR is #216.

hakonanes commented 6 months ago

216 should be ready to be merged into the main branch, and we can then release a 0.6rc1 tag.

I assume you're busy the HyperSpy workshop, @CSSFrancis. Since you're the one asking for the release, we can wait until you give the go-ahead.

CSSFrancis commented 6 months ago

@hakonanes I'll wait until the CI finishes and then merge then we can go ahead!

hakonanes commented 6 months ago

Here're my suggested release notes (https://github.com/pyxem/diffsims/releases):


diffsims 0.6rc1 is a minor release of diffsims, an open source Python library focussed on the simulation of diffraction patterns.

See below, the changelog or the GitHub changelog for all updates from the previous release.

Added

Changed

Deprecated

Removed

hakonanes commented 6 months ago

0.6rc1 is out on PyPI. Can be installed with pip install --pre diffsims.

We could make a pre-release build on conda-forge (explained here), but I don't think it's necessary.

@CSSFrancis, what needs to be done before we release 0.6.0 proper?

CSSFrancis commented 6 months ago

@hakonanes thank you so much for your help with this! I don't think we really want to do a pre-release on cond-forge (just sounds like a lot of work).

As far as a workflow before relasing 0.6.0 proper:

  1. Merge https://github.com/pyxem/pyxem/pull/1076
  2. Rerun https://github.com/din14970/pyxem_template_matching_workflows. I would like to rerun the benchmarks/ update those workflows using the new simulations. This is a good test to see if things are (still) running effectively.

We don't necessarily need to merge everything but as I don't do much in the way of orientation mapping I would love to have some feed back before things get merged. My current goal is to make a pyxem 0.19.0 rc hopefully tomorrow and then we can do some testing with that.

CSSFrancis commented 5 months ago

I think we can probably go ahead with this. I've been using this for a couple of weeks now with no issues so we can make the 0.6.0 release.

hakonanes commented 5 months ago

Sounds good, I'll do it right away.

hakonanes commented 5 months ago