Closed hakonanes closed 6 months ago
@CSSFrancis, I listed you as a maintainer alongside Duncan, Phillip, and myself in the release info. Which I thought you already were. I hope this is OK?
Great and great!
Thanks for looking it over. We should be good to merge and release once your doc examples PR is in.
Description of the change
Release prep:
Other changes:
StructureLibrary.from_crystal_systems()
. The method previously threw a NotImplementedError, but will now throw an AttributeError. Mentioned in the changelog under Removed.Rotation.from_neo_euler()
withRotation.from_axes_angles()
.I've cleaned up the test suite a bit:
xfail(error)
withwith pytest.raises(error):
. To me, it seems like best practice is to use the latter when we intentionally raise errors in the code, while the former is mostly used as a temporary measure for bugs that will be fixed.plt.close()
(silencing a warning of > 20 open plots from Matplotlib)Progress of the PR
For reviewers
__init__.py
.CHANGELOG.rst
.credits
indiffsims/release_info.py
and in.zenodo.json
.