Fix default EBSD.detector attribute shape when detector is not passed upon initialization - Githubissues

pyxem / kikuchipy

Toolbox for analysis of electron backscatter diffraction (EBSD) patterns

https://kikuchipy.org

GNU General Public License v3.0

79 stars 30 forks source link

Fix default EBSD.detector attribute shape when detector is not passed upon initialization #603

Closed hakonanes closed 1 year ago

hakonanes commented 1 year ago

Description of the change

Fix default EBSD.detector attribute shape when detector is not passed upon initialization.

Progress of the PR

[n/a] Docstrings for all functions
[x] Unit tests with pytest for all lines
[x] Clean code style by running black via pre-commit

Minimal example of the bug fix or new feature

>>> import numpy as np
>>> import kikuchipy as kp
>>> s = kp.signals.EBSD(np.ones((1, 2, 3, 4))
>>> s.detector.shape
(3, 4)  # (4, 3) before this fix (ouch!)

For reviewers

[ ] The PR title is short, concise, and will make sense 1 year later.
[ ] New functions are imported in corresponding __init__.py.
[ ] New features, API changes, and deprecations are mentioned in the unreleased section in CHANGELOG.rst.
[ ] New contributors are added to release.py, .zenodo.json and .all-contributorsrc with the table regenerated.