pyxem / kikuchipy

Toolbox for analysis of electron backscatter diffraction (EBSD) patterns
https://kikuchipy.org
GNU General Public License v3.0
79 stars 30 forks source link

Fix EDAX-Bruker (PCy, PCz) conversion for rectangular detectors #604

Closed hakonanes closed 1 year ago

hakonanes commented 1 year ago

Description of the change

This PR changes the EDAX->Bruker (PCy, PCz) conversion for rectangular detectors. The correct conversion is as follows:

PCy = 1 - y/Ny PCz = z / min(Nx, Ny)

where (PCy, PCz) are the Bruker projection center (PC) y and z coordinates, (Nx, Ny) are the number of detector columns and rows, and (y, z) are the EDAX TSL PC y and z coordinates.

The Oxford->Bruker conversion stays the same.

This change follows the same change coming in a new version of PyEBSDIndex (relevant commit https://github.com/drowenhorst-nrl/PyEBSDIndex/commit/ea22dfd3c2c8f7de60d4d3750db1a85ec1be1369). Hence, we should wait to merge this until a new version of PyEBSDIndex is available with this change.

Progress of the PR

For reviewers

hakonanes commented 1 year ago

This PR will be added to another PR preparing a 0.9 release compatible with PyEBSDIndex v0.2.