Set minimal version of orix to >= 0.11.1

pyxem / kikuchipy

Toolbox for analysis of electron backscatter diffraction (EBSD) patterns

https://kikuchipy.org

GNU General Public License v3.0

80 stars 30 forks source link

Set minimal version of orix to >= 0.11.1 #623

Closed Erlendos12 closed 1 year ago

Erlendos12 commented 1 year ago

Description of the change

Set minimal version of orix to >= 0.11.1

For reviewers

[x] The PR title is short, concise, and will make sense 1 year later.
[n/a] New functions are imported in corresponding __init__.py.
[x] New features, API changes, and deprecations are mentioned in the unreleased section in CHANGELOG.rst.
[x] New contributors are added to release.py, .zenodo.json and .all-contributorsrc with the table regenerated.

hakonanes commented 1 year ago

Thank you for reporting #620 which lead to the fix in orix 0.11.1 and then this PR!

Would be nice if you could add a one-liner under "Changed" in CHANGELOG.rst as well.

I'll add your name (Erlend Mikkelsen Østvold) to the package credits in kikuchipy/release.py and .zenodo.json (NTNU as your affiliation) as well as the contributors table in the README to this PR. Is this OK with you?

Erlendos12 commented 1 year ago

Thank you for reporting #620 which lead to the fix in orix 0.11.1 and then this PR!

Would be nice if you could add a one-liner under "Changed" in CHANGELOG.rst as well.

I'll add your name (Erlend Mikkelsen Østvold) to the package credits in kikuchipy/release.py and .zenodo.json (NTNU as your affiliation) as well as the contributors table in the README to this PR. Is this OK with you?

Yes! I thought maybe I had to create the pull request first in order to refer to it in the changelog. I am ok with being added to contributers, thank you.

hakonanes commented 1 year ago

True, the manual way we create the changelog isn't perhaps the most convenient... I determine the next GitHub repo ID by checking the latest IDs among issues, PRs and discussions. But this procedure isn't written anywhere...

Just ping me when the PR is ready for review (should be quick)!

Erlendos12 commented 1 year ago

@hakonanes The PR should be ready for review now!:)

hakonanes commented 1 year ago

Next time, I suggest to name your branch something else than develop or main, which is a little bit easier to keep track of when pulling your changes locally. (Lots to think about...)