pyxem / kikuchipy

Toolbox for analysis of electron backscatter diffraction (EBSD) patterns
https://kikuchipy.org
GNU General Public License v3.0
78 stars 30 forks source link

Maintain not-indexed points in refined crystal maps #632

Closed hakonanes closed 1 year ago

hakonanes commented 1 year ago

Description of the change

This PR ensures not-indexed points in a crystal map are maintained after EBSD refinement (refine_orientation() and refine_orientation_projection_center()). It fixes the issue in #622, reported by @Erlendos12 (thanks).

This fix changes the API of the above mentioned refinement methods in that not-indexed points are kept as not-indexed, instead of not being part of the data (False in CrystalMap.is_in_data) as is the case in the current release. I consider the current behavior as a bug, and will therefore release this change as a patch.

I re-ran and saved tutorials with stored cell outputs affected by this change.

This fix will constitute a new 0.8.4 patch release, released after this PR is merged. I hope to do this before April 5th.

Progress of the PR

For reviewers

Erlendos12 commented 1 year ago

Great! This will eliminate having to create masks to remove not_indexed orientations when refining. 👍

hakonanes commented 1 year ago

This should be done and merged soon, so that 0.8.4 is released later today.