Improve EBSD detector string representation, force float data type - Githubissues

pyxem / kikuchipy

Toolbox for analysis of electron backscatter diffraction (EBSD) patterns

https://kikuchipy.org

GNU General Public License v3.0

78 stars 30 forks source link

Improve EBSD detector string representation, force float data type #677

Closed hakonanes closed 1 month ago

hakonanes commented 1 month ago

Description of the change

Addresses:

Progress of the PR

[x] Docstrings for all functions
[x] Unit tests with pytest for all lines
[x] Clean code style by running black via pre-commit
[x] Update documentation accordingly

Minimal example of the bug fix or new feature

>>> import kikuchipy as kp
>>> s = kp.data.nickel_ebsd_small()
>>> s.detector
EBSDDetector(shape=(60, 60), pc=(0.425, 0.213, 0.501), sample_tilt=70.0, tilt=0.0, azimuthal=0.0, binning=8.0, px_size=1.0 um)

For reviewers

[ ] The PR title is short, concise, and will make sense 1 year later.
[ ] New functions are imported in corresponding __init__.py.
[ ] New features, API changes, and deprecations are mentioned in the unreleased section in CHANGELOG.rst.
[ ] New contributors are added to release.py, .zenodo.json and .all-contributorsrc with the table regenerated.

review-notebook-app[bot] commented 1 month ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB