Closed hakonanes closed 1 year ago
@anderscmathisen, I've updated the contributing guide informing that calls like pip install -e .[doc]
must be replaced by pip install -e '.[doc]'
with zsh
shells (Apple's replacement of good ol' bash
in newer OS'). Thank you for reporting this issue (in person)!
Thanks a lot for reviewing, @harripj!
Description of the change
Add
row
andcolumn
attributes toCrystalMap
to keep track of map point indices. This was necessary to clearly demonstrate indexing/slicing of crystal maps in a new example (see docs built from this PR).All other changes are related to silencing of many warnings in the tests, some type hints, and removal of setting of parameters with the default values (unnecessary).
Progress of the PR
Minimal example of the bug fix or new feature
See example in the docs built from this PR.
For reviewers
__init__.py
.CHANGELOG.rst
.__credits__
inorix/__init__.py
and in.zenodo.json
.