pyxem / orix

Analysing crystal orientations and symmetry in Python
https://orix.readthedocs.io
GNU General Public License v3.0
79 stars 45 forks source link

Remove deprecated z coordinate in CrystalMap and related "3D functionality" #427

Closed hakonanes closed 1 year ago

hakonanes commented 1 year ago

Description of the change

The appearance of "3D functionality" in the CrystalMap (implemented by me, but never tested on a real 3D dataset for its usefulness) was deprecated in 0.10.1 and will be removed in 0.11.0. This PR makes the necessary changes to the class, the plotting and IO plugins (orix HDF5 and ang).

The only issue I can see is that people have stored 3D datasets in orix' HDF5 format, which they now cannot read back with the changed orix HDF5 reader. I hope no-one has done this, but if they have, let's hope they shout out in an issue so we can fix this.

Progress of the PR

For reviewers