CI: Add pre-commit CI

pyxem / orix

Analysing crystal orientations and symmetry in Python

https://orix.readthedocs.io

GNU General Public License v3.0

80 stars 48 forks source link

CI: Add pre-commit CI #472

Closed CSSFrancis closed 6 months ago

CSSFrancis commented 6 months ago

This adds lines to pre-commit for CI to run isort and black from a comment to a PR.

For reviewers

[x] The PR title is short, concise, and will make sense 1 year later.
[x] New functions are imported in corresponding __init__.py.
[x] New features, API changes, and deprecations are mentioned in the unreleased section in CHANGELOG.rst.
[x] Contributor(s) are listed correctly in __credits__ in orix/__init__.py and in .zenodo.json.

CSSFrancis commented 6 months ago

@pc494 Can you add access to orix from https://pre-commit.ci

pc494 commented 6 months ago

pre-commit.ci autofix

pc494 commented 6 months ago

at a guess this failure is due to the style changes between 2023 and 2024. @CSSFrancis could you run locally so this comes up green as I imagine we need this merged before we can autofix.

CSSFrancis commented 6 months ago

@pc494 Yep you are correct. The joys of running black :)

CSSFrancis commented 6 months ago

@pc494 This should be fixed now and we can auto fix now which is nice.

pc494 commented 6 months ago

I am going to merge this on the condition that @CSSFrancis remembers to add himself to the Zenodo when we get to #460. This PR closes #463.