pyxem / orix

Analysing crystal orientations and symmetry in Python
https://orix.readthedocs.io
GNU General Public License v3.0
78 stars 45 forks source link

[pre-commit.ci] pre-commit autoupdate #490

Closed pre-commit-ci[bot] closed 2 months ago

pre-commit-ci[bot] commented 2 months ago

updates:

hakonanes commented 2 months ago

Since the pre-commit bot pushes a branch, all checks are run twice. Can someone explain briefly why (security, maintenance etc.) we need these auto-update-PRs?

harripj commented 2 months ago

We should be able to disable the checks if the PR is opened by the pre-commit-ci bot: https://docs.github.com/en/actions/using-jobs/using-conditions-to-control-job-execution and the example here would suggest that if: ${{ github.actor != 'pre-commit-ci[bot]' }} should work

hakonanes commented 1 month ago

I've addressed this in https://github.com/pyxem/orix/pull/504.