search

pyxem / orix

Analysing crystal orientations and symmetry in Python
https://orix.readthedocs.io
GNU General Public License v3.0
79 stars 46 forks source link

Numpy 2.0.0 problems #506

Open pc494 opened 1 month ago

pc494 commented 1 month ago

This has filtered down from upstream (see https://github.com/pyxem/pyxem/issues/1099). quaternion on which we depend is currently (and may not for some time be) compatible with numpy 2.0.0.

It's possible we could drag and drop a sister package in place (see discussion https://github.com/moble/quaternion/issues/229) but I'm acutely aware this project is really short of dev resourcing.

The alternative is that we make ourselves numpy 1.x for now.

CSSFrancis commented 1 month ago

@pc494 I'm going to try to make the switch this week when I have the time! (Which I should)

hakonanes commented 1 week ago

As I mentioned in #507:

The dependency on numpy-quaternion is NOT important. We only use it for quaternion-quaternion and quaternion-vector multiplication. Our "old" implementation used Numba, and as far as I can remember, it was only twice as slow. If numpy-quaternion becomes a hassle, I'd suggest we make it an optional dependency: use it when available, but fall back to Numba if it's not. What do you think?

pc494 commented 6 days ago

Sorry @hakonanes I had completely forgotten the #507 discussion when I opened this.

hakonanes commented 6 days ago

Nono, you opened this long before my post, I just reposted here to say that we're on it (: