search

pyxem / pyxem-demos

Examples and tutorials of multi-dimensional diffraction microscopy workflows using pyxem.
30 stars 38 forks source link

V0.10.0 #29

Closed dnjohnstone closed 4 years ago

dnjohnstone commented 4 years ago

demo 02 is currently not correct for pattern matching. I think that this is due to pyxem#492 changing how the library should be generated.

dnjohnstone commented 4 years ago

demo04 also has a pattern matching bug due to #492 demo05 may have a bug in vector based strain mapping, unsure where that's from though demo06 also has some bugs linked to the final PR needed for 0.10.0

dnjohnstone commented 4 years ago

@pc494 please could you have a look at demo 2 and 4 on this branch and update them for the new template library generation behaviour.

Please could you also look at 5 and see if you agree there is an issue in the vector based strain mapping?

If those are tied up then I think we just have the nanocrystal segmentation to finish for 0.10.0

pc494 commented 4 years ago

Changing the center_of_mass_method() argument to 20 (ie - larger square investigated) seems to fix the problem in Book 5.

EDIT: This is now in my PR to the local branch.