pyxem / pyxem-demos

Examples and tutorials of multi-dimensional diffraction microscopy workflows using pyxem.
30 stars 38 forks source link

pyxem-demos 0.11.0 #43

Closed dnjohnstone closed 4 years ago

dnjohnstone commented 4 years ago

Tidying up in advance of a v0.11.0 release has highlighted some issues with the demos as they stand, which need to be fixed before release:

@pc494 @tinabe @JoonatanL @CSSFrancis - it would be much appreciated if you could each have a look at the issue above that corresponds to code you contributed significantly to.

pc494 commented 4 years ago

I'll handle the two problems in demo-02.

tinabe commented 4 years ago

demo-06: It seems that the error in demo-06 is caused by "max_size = None", which should be "max_size = np.inf" (defined a few lines earlier in the notebook).

Two other things I noticed:

dnjohnstone commented 4 years ago

Thanks @tinabe - I've updated the demo notebooks and I think fixed the segments.py thing here: https://github.com/pyxem/pyxem/pull/593

dnjohnstone commented 4 years ago

Ok @pc494 I think we're at the point where it's now just fix demo 02 and then I'll do the 0.11.0 release

pc494 commented 4 years ago

Sorry, missed this when it came in. Will be on it start of play tomorrow.

pc494 commented 4 years ago

44 should be the end of this set.