Closed dnjohnstone closed 4 years ago
I'll handle the two problems in demo-02.
demo-06: It seems that the error in demo-06 is caused by "max_size = None", which should be "max_size = np.inf" (defined a few lines earlier in the notebook).
Two other things I noticed:
Thanks @tinabe - I've updated the demo notebooks and I think fixed the segments.py thing here: https://github.com/pyxem/pyxem/pull/593
Ok @pc494 I think we're at the point where it's now just fix demo 02 and then I'll do the 0.11.0 release
Sorry, missed this when it came in. Will be on it start of play tomorrow.
Tidying up in advance of a v0.11.0 release has highlighted some issues with the demos as they stand, which need to be fixed before release:
@pc494 @tinabe @JoonatanL @CSSFrancis - it would be much appreciated if you could each have a look at the issue above that corresponds to code you contributed significantly to.