01 - Error running the new center_direct_beam routine

pyxem / pyxem-demos

Examples and tutorials of multi-dimensional diffraction microscopy workflows using pyxem.

29 stars 38 forks source link

01 - Error running the new center_direct_beam routine #49

Closed pc494 closed 3 years ago

pc494 commented 3 years ago

pxyem 0.13.0-rc.1.dev #(from pip)

@magnunor would you mind seeing if you can replicate the following?

demo01

pc494 commented 3 years ago

Curiously it works fine in demo 06.

Retraction: It didn't throw an error, but it's working very very slowly.

magnunor commented 3 years ago

Looking at this now. For demo 01 it is at least due to half_square_width in combination with the automatic rechunking pull request.

Making a fix for this.

pc494 commented 3 years ago

Don't worry about the demo 06 bit, I'm not sure it's a code problem just yet.

magnunor commented 3 years ago

@pc494, the bug you saw in demo 01 will depend on the size of the dataset. For datasets smaller than 30 MiB the dataset will fit inside one chunk, avoiding the issue.

This has been fixed in https://github.com/pyxem/pyxem/pull/712

pc494 commented 3 years ago

This was fine when I tested for #61, closing.