search

pyxem / pyxem-demos

Examples and tutorials of multi-dimensional diffraction microscopy workflows using pyxem.
29 stars 38 forks source link

load syntaxes broken in some demos #57

Closed maclariz closed 3 years ago

maclariz commented 3 years ago

pxm.load('filename.extension') does not work in 13.0

I downgraded to 12.3 and it works fine.

Your sheet 01 GaAs Nanowire - Data Inspection - Preprocessing - Unsupervised Machine Learning.ipynb

does not run under 13.0 as a result

Ian

pc494 commented 3 years ago

Hi Ian,

I think this is a feature and not a bug; after discussion pyxem/pyxem#711 we decided to keep it that way.

(fingers crossed) hs.load should work just fine

maclariz commented 3 years ago

OK

Just new to this. If you are happy with loading as hs objects, then we are all good. Just python numpties up here just making our first halting steps into the world of pyxem since we want to do some SVD on our noisy data and then index it…

Best wishes

Ian

On 29 Jan 2021, at 17:36, Phillip Crout notifications@github.com<mailto:notifications@github.com> wrote:

Hi Ian,

I think this is a feature and not a bug; after discussion pyxem/pyxem#711https://github.com/pyxem/pyxem/issues/711 we decided to keep it that way.

(fingers crossed) hs.load should work just fine

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/pyxem/pyxem/issues/719#issuecomment-769945455, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APHUIKTU42OL4LCXGTXFGZLS4LWZBANCNFSM4WZGTAPQ.

maclariz commented 3 years ago

Phillip, Revisiting that tutorial notebook at some point might be a good plan

Ian

On 29 Jan 2021, at 17:45, Ian MacLaren Ian.MacLaren@glasgow.ac.uk<mailto:Ian.MacLaren@glasgow.ac.uk> wrote:

OK

Just new to this. If you are happy with loading as hs objects, then we are all good. Just python numpties up here just making our first halting steps into the world of pyxem since we want to do some SVD on our noisy data and then index it…

Best wishes

Ian

On 29 Jan 2021, at 17:36, Phillip Crout notifications@github.com<mailto:notifications@github.com> wrote:

Hi Ian,

I think this is a feature and not a bug; after discussion pyxem/pyxem#711https://github.com/pyxem/pyxem/issues/711 we decided to keep it that way.

(fingers crossed) hs.load should work just fine

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/pyxem/pyxem/issues/719#issuecomment-769945455, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APHUIKTU42OL4LCXGTXFGZLS4LWZBANCNFSM4WZGTAPQ.

pc494 commented 3 years ago

Dealt with by #61