pyxem / pyxem-demos

Examples and tutorials of multi-dimensional diffraction microscopy workflows using pyxem.
30 stars 38 forks source link

02 GaAs Nanowire - Phase Mapping - Orientation Mapping not compatible with current pyxem release #82

Closed uellue closed 1 year ago

uellue commented 1 year ago

When I run the notebook 02 GaAs Nanowire - Phase Mapping - Orientation Mapping with pyxem 0.15.1 I get the following error message:

image

...and if I try one of the suggested alternatives:

image

uellue commented 1 year ago

FYI in LiberTEM we routinely run example notebooks in CI and also trigger CI runs across repositories to manage cross-dependencies. That would have caught this automatically. If you like we can help you to set it up for pyxem, CC @sk1p!

CSSFrancis commented 1 year ago

@uellue Running notebooks in the CI has been on my todo list for a little bit now but this shows exactly why it is important!

I'll see if I can track down the bug and get this fixed!

CSSFrancis commented 1 year ago

Weird.. So I fixed this notebook in the documentation but apparently not the demo... https://pyxem.readthedocs.io/en/latest/demos/02%20GaAs%20Nanowire%20-%20Phase%20Mapping%20-%20Orientation%20Mapping.html