search

pyxem / pyxem-demos

Examples and tutorials of multi-dimensional diffraction microscopy workflows using pyxem.
29 stars 38 forks source link

Testing Adding CI #85

Closed CSSFrancis closed 1 year ago

CSSFrancis commented 1 year ago

Testing adding in CI similar to kikchipy's testing of their documentation

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

CSSFrancis commented 1 year ago

This doesn't necessarily fix 02 and 11 but it does help to test to make sure that the demos are running and up to date.

Maybe testing these in the main pyxem repo makes more sense than testing that the notebooks run here but something is better than nothing.

CSSFrancis commented 1 year ago

Reference to #82

CSSFrancis commented 1 year ago

@hakonanes I copied a lot of the kikchipy workflow for this so if you have the chance to look at the github action that would be great!

CSSFrancis commented 1 year ago

Okay the only notebook that isn't passing now is 02. That one might take a bit more effort and potentially a bug fix upstream to pyxem. It appears that a change in diffsims wasn't properly being tested in pyxem so I'll need to make that bug fix.