search

pyxem / pyxem

An open-source Python library for multi-dimensional diffraction microscopy.
https://pyxem.readthedocs.io
GNU General Public License v3.0
151 stars 84 forks source link

Repetitive indexing changes the input signal? #1100

Open OverEthanol opened 4 months ago

OverEthanol commented 4 months ago

Hi, I am not sure if this is a bug or an intended feature. Suppose that I have loaded and processed some TEM diffraction pattern as variable s_pol_gamma and it looks like this (done with s_pol_gamma.plot(gamma=0.1) and all the following plots are plotted in the same way):

image

Then I performed the indexing by 

result = s_pol_gamma.get_orientation(simulation=sim, n_best=10, frac_keep=1.0)

and when I plot out s_pol_gamma again, now it looks like this

image

and if I do it again, then

image

and again...

image

It seems like the electron counts values just keep dropping down the more repetitive indexing I do on the same signal. Is this because each time when indexing is performed, it takes away the pixel values that are matching...??? I don't know understand :D

pc494 commented 4 months ago

I'm going to label this as a bug for now, I'm not sure we have the resources to look into it though :(

CSSFrancis commented 3 months ago

@OverEthanol I think I have some time today to look into this. Hopefully we can get a bug fix out rather quickly!

CSSFrancis commented 3 months ago

@OverEthanol What version of pyxem do you have? This was a bug in 0.19.0 but should have been fixed in 0.19.1!