search

pyxis-roc / gpu-api-interposer

GPU API interposer generation tools plus libcuda (CUDA Device API) and libcudart (CUDA Runtime API) interposers. Also includes harmonv, for now.
2 stars 0 forks source link

Added Cython and pkgconfig to requirements in setup.py #4

Closed bavalpey closed 3 years ago

bavalpey commented 3 years ago

I tried to install on a fresh venv and ran into issues where cython and pkgconfig were required. (there may be other dependencies that are installed in other sub-packages of ROCetta). Adding these two packages to the install_requires field fixed this issue.

sree314 commented 3 years ago

I ran python setup.py install (and also develop) and I don't get any errors.

These are definitely not something libcuda-replay needs, I suspect they're pycapnp requirements. However, pycapnp installed without issues as well from a wheel.

Can you tell me a little bit more about the environment and the error messages you get?

bavalpey commented 3 years ago

I ran python setup.py install (and also develop) and I don't get any errors.

These are definitely not something libcuda-replay needs, I suspect they're pycapnp requirements. However, pycapnp installed without issues as well from a wheel.

Can you tell me a little bit more about the environment and the error messages you get?

Sure,

pkgconfig error $pip install . develop Processing /localdisk/bvalpey/rocetta_scratches/ROCetta/gpu-api-interposer/libcuda-replay Collecting develop Downloading https://files.pythonhosted.org/packages/20/70/a616ab2c472a046d3ff78bd9ea8f2a3ca41feb0e1711b42d7d4416d22b4d/develop-0.1.4.tar.gz Collecting pycapnp (from libcudareplay==0.1) Downloading https://files.pythonhosted.org/packages/f1/64/459456d46d821285a0832e7284bd977731477a639624270379088556155c/pycapnp-1.1.0.tar.gz (560kB) 100% |████████████████████████████████| 563kB 381kB/s Complete output from command python setup.py egg_info: Traceback (most recent call last): File "", line 1, in File "/tmp/pip-build-ymn8fgrw/pycapnp/setup.py", line 12, in import pkgconfig ModuleNotFoundError: No module named 'pkgconfig' ---------------------------------------- Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-ymn8fgrw/pycapnp/
error for cython $pip install . develop Processing /localdisk/bvalpey/rocetta_scratches/ROCetta/gpu-api-interposer/libcuda-replay Collecting develop Using cached https://files.pythonhosted.org/packages/20/70/a616ab2c472a046d3ff78bd9ea8f2a3ca41feb0e1711b42d7d4416d22b4d/develop-0.1.4.tar.gz Collecting pycapnp (from libcudareplay==0.1) Using cached https://files.pythonhosted.org/packages/f1/64/459456d46d821285a0832e7284bd977731477a639624270379088556155c/pycapnp-1.1.0.tar.gz Complete output from command python setup.py egg_info: Traceback (most recent call last): File "", line 1, in File "/tmp/pip-build-pa16emwk/pycapnp/setup.py", line 108, in from Cython.Distutils import build_ext as build_ext_c # noqa: E402 ModuleNotFoundError: No module named 'Cython' ---------------------------------------- Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-pa16emwk/pycapnp/
sree314 commented 3 years ago

FWIW, I think pycapnp installation is actually broken. The Makefile is fine. I'm going to merge this, but we should revisit this.