search

pyxu-org / pyxu

Modular and scalable computational imaging in Python with GPU/out-of-core computing.
https://pyxu-org.github.io/
MIT License
117 stars 17 forks source link

V2 dev #23

Closed okumuskaan closed 2 years ago

okumuskaan commented 2 years ago

Universal functions are implemented in pycsou/operator/map/ufunc.py and tested in pycsou_tests/operator/examples/test_ufunc.py. All these functions are passed the testings successfully.

SepandKashani commented 2 years ago

@okumuskaan I'm 75% through the review. My overall impression is positive, but there are many points to discuss/fix before this can be merged. I have copied your branch into v2_kaan_review with several improvements + inline comments for you and @matthieumeo.

@matthieumeo We should discuss some of these points before recommending a path forward for @okumuskaan .

matthieumeo commented 2 years ago

@SepandKashani Should we close this PR since the development is now happening on the v2_kaan_review branch? The branch that triggered this PR will not be updated anymore if I understood correctly?

SepandKashani commented 2 years ago

Yes, we can close it. À new PR will be made once ready.

On Wed, 4 May 2022, 08:21 Matthieu SIMEONI, @.***> wrote:

@SepandKashani https://github.com/SepandKashani Should we close this PR since the development is now happening on the v2_kaan_review branch? The branch that triggered this PR will not be updated anymore if I understood correctly?

— Reply to this email directly, view it on GitHub https://github.com/matthieumeo/pycsou/pull/23#issuecomment-1116966475, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGGWPKZ3SWJ45OVVQL6LFBLVIIJPFANCNFSM5T6KXRKA . You are receiving this because you were mentioned.Message ID: @.***>